incorrect multiple parameter assignment

[vanhauser-thc]

Code

    let matches = App::new("test")
        .about("test")
        .arg(
            Arg::with_name("dictionary")
                .short("x")
                .value_name("DICTIONARY")
                .takes_value(true)
                .multiple(true)
                .help("Dictionary file to use, can be specified multiple times."),
        )
        .arg(
            Arg::with_name("statstime")
                .short("T")
                .value_name("STATSTIME")
                .takes_value(true)
                .help("How often to print statistics in seconds [default: 5, disable: 0]"),
        )
        .arg(Arg::with_name("workdir")
                               .help("Where to write the corpus, also reads the data on start. If more than one is supplied the first will be the work directory, all others will just be initially read from.")
                                .multiple(true)
                                .value_name("WORKDIR")
                               )
        .get_matches();

    let mut dictionary: Option<Vec<String>> = None;
    if matches.is_present("dictionary") {
        dictionary = Some(values_t!(matches, "dictionary", String).unwrap_or_else(|e| e.exit()));
    }

    if dictionary != None {
        for file in dictionary.unwrap() {
            println!("dic: {}", file);
        }
    }

Version

rustc 1.48.0 (7eac88abb 2020-11-16)

Actual Behavior Summary

$ .main  -x a -x b  foo bar
dic: a
dic: b
dic: foo
dic: bar

$ .main  -x a -x b  -T 5 foo bar
dic: a
dic: b

Expected Behavior Summary

the "foo" and "bar" parameters should not be part of the gathered -x options.

[pksunkara]

Why did you not use the issue template? I have no idea what clap version you are using.

[vanhauser-thc]

sorry this is my first rust related issue and the template had things I didnt know/recognize. I am very new to Rust ... :(

name = "clap"
version = "2.33.3"

[pksunkara]

What exactly did you have trouble in the template with? We built such that even a new user to rust and clap should be able to follow it.

We fixed this particular issue in v3 using https://docs.rs/clap/3.0.0-beta.2/clap/struct.Arg.html#method.multiple_occurrences.

Replace multiple with the above method.