Move to AndroidX prompt #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeirola
commented
Oct 15, 2019
| Runnable myRunnable = new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| mBiometricPrompt.authenticate(promptInfo); |
There was a problem hiding this comment.
Had some issues with FragmentManager throwing errors when this was not run in the main thread. This is also mentioned in the FragmentManager documentation https://developer.android.com/reference/androidx/fragment/app/FragmentManager.html#executePendingTransactions()
aeirola
commented
Oct 15, 2019
| @@ -317,6 +327,6 @@ private String decryptBytes(Key key, byte[] bytes) throws CryptoFailedException, | |||
|
|
|||
| @Override | |||
| public void setCurrentActivity(Activity activity) { | |||
| mActivity = activity; | |||
| mActivity = (FragmentActivity) activity; | |||
There was a problem hiding this comment.
Since the BiometricPrompt uses Fragments, the activity now needs to be a FragmentActivity. New versions of ReactNative seem to provide FragmentActivities, so this cast seems to work.
|
Okay, seems like you already implemented similar changes in the branch. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issues with the code in oblador#195 related to the biometric prompt not working correctly on certain devices. This was fixed in the latest AndroidX releases (https://stackoverflow.com/a/57085599), so needed to move to AndroidX to fix the issue.
Since there were talks about moving to AndroidX in the feature PR, I thought I'd share the work I done with you in case you have some use for it.