feat: Add label + assignee select in PR submission #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
refcell
approved these changes
Nov 5, 2024
refcell
reviewed
Nov 5, 2024
Comment on lines
+304
to
+317
| let set_assignee = inquire::Confirm::new("Would you like to assign the pull request?") | ||
| .with_default(false) | ||
| .prompt()?; | ||
| let assignees = set_assignee | ||
| .then(|| { | ||
| let answer = inquire::Text::new("Assignees (comma-separated):") | ||
| .prompt()? | ||
| .replace(' ', "") | ||
| .split(',') | ||
| .map(ToString::to_string) | ||
| .collect(); | ||
| Ok::<_, StError>(answer) | ||
| }) | ||
| .transpose()?; |
There was a problem hiding this comment.
Still think it would be cool if there was an environment variable or global setting that allowed you to automagically set a default assignee.
e.g. if I have ST_DEFAULT_ASSIGNEE=refcell set, st doesn't prompt me for an assignee here.
refcell
requested changes
Nov 5, 2024
Comment on lines
+294
to
+299
| Some( | ||
| selected_labels | ||
| .into_iter() | ||
| .map(|label| label.name) | ||
| .collect(), | ||
| ) |
There was a problem hiding this comment.
There's an issue here. Octocrab will error if it gets an empty vec. This should return Option::None if selected_labels is empty.
e.g. error response:
🐙 octocrab error: GitHub { source: GitHubError { documentation_url: Some("https://docs.github.com/rest/issues/labels#add-labels-to-an-issue"), errors: None, message: "Invalid request.\n\nNo subschema in \"anyOf\" matched.\nFor 'anyOf/0', {\"labels\"=>[]} is not an array.\nFor 'anyOf/1', {\"labels\"=>[]} is not an array.\n1 item required; only 0 were supplied.", status_code: 422 }, backtrace: <disabled> }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds two more selects to the PR submission process to select labels and assignees for the PR.
Example
Screen.Recording.2024-11-04.at.12.10.23.PM.mov
Metadata
closes #36