Detect target inside a shadow root for clickOutsideHandler #7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR and the issue report. Do you think you'd be able to add a test to this PR? |
|
I'll look into it! |
| if ( !activator() ) { | ||
| return; | ||
| } | ||
|
|
||
| for ( const contextElement of contextElements ) { | ||
| if ( contextElement.contains( target ) ) { | ||
| if ( contextElement.contains( domEvt.target ) || | ||
| ( 'composedPath' in domEvt && domEvt.composedPath().includes( contextElement ) ) ) { |
There was a problem hiding this comment.
Maybe add a comment on why you're checking for the existence of composedPath. I'm not sure how this project tracks browser support, but they may want to remove then when all supported browsers have native shadow DOM.
There was a problem hiding this comment.
A comment would great! We don't unfortunately track such things in a more organized way yet, so a comment is the best we can do for now.
|
Since I am not able to apply minor changes, I must close the PR and create another one.
|
|
=> #7779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (ui): Look at event's composed path to detect a target in shadow root. Closes #7743.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.