Improve performance by caching model node index and offset in Node and NodeList
#17296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data set, without all tooling around it.
…not treated as manual tests.
Added button to start the test, instead starting it automatically, so CI does not wait for it. Changed structure a bit, again. Removed existing `editorinit.html` test to prevent confusion.
…lement` and `model.DocumentFragment`. Other (engine): Node index and offset related values are now cached in `Node` and `NodeList` to improve performance.
…e position exists in current model tree. Internal (engine): Used `Position#isValid()` to better validate selection ranges. Tests (engine): Changed error messages expected in some tests. Now different errors may be thrown than earlier because internal execution logic changed a bit. New error codes are more precicse.
niegowski
changed the base branch from
master
to
cc/performance-research-base
niegowski
reviewed
Oct 22, 2024
Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
Dumluregn
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (engine): Introduced
getChildAtOffset()method formodel.Elementandmodel.DocumentFragment.Feature (engine): Introduced
Position#isValid()to check whether the position exists in current model tree.Other (engine): Node index and offset related values are now cached in model
NodeandNodeListto improve performance.Internal (engine): Used
Position#isValid()to better validate selection ranges.Tests (engine): Changed error messages expected in some tests. Now different errors may be thrown than earlier because internal execution logic changed a bit. New error codes are more precicse.
Additional information
Based on: #17205