Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use realistic watermarks for code coverage reports #9956

Closed
oleq opened this issue Jun 25, 2021 · 1 comment · Fixed by ckeditor/ckeditor5-dev#713
Closed

Use realistic watermarks for code coverage reports #9956

oleq opened this issue Jun 25, 2021 · 1 comment · Fixed by ckeditor/ckeditor5-dev#713
Assignees
@oleq
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 44 (v29...

Comments

@oleq
Copy link
Member

oleq commented Jun 25, 2021 •
edited
Loading

📝 Provide a description of the improvement

The project requires 100% CC and CI will fail unless this requirement is met. However, when developing, the CC report is misleading by displaying values less than 100% as green:

This should be

instead. Currently, the report gives developers a false sense of security and they will need to revisit their code when CI is done (which is annoying).

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. squad:platform Issue to be handled by the Platform team. package:dev labels Jun 25, 2021
@oleq oleq added this to the iteration 44 milestone Jun 25, 2021
@oleq oleq self-assigned this Jun 25, 2021
@oleq oleq mentioned this issue Jun 25, 2021
Merged
@oleq
Copy link
Member Author

oleq commented Jun 25, 2021

Another before/after:

pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Jun 28, 2021
@pomek
Merge pull request #713 from ckeditor/ck/9956-improved-coverage-water…
d194777 
…marks

Other (tests): Set watermarks for code coverage reports so anything less than 100% is instantly visible. Closes ckeditor/ckeditor5#9956.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 44 (v29.0.0)
Development

Successfully merging a pull request may close this issue.

Better CC watermarks ckeditor/ckeditor5-dev
1 participant
@oleq