Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the list of manual tests and in-test navigation #9843

Closed
oleq opened this issue Jun 9, 2021 · 0 comments · Fixed by ckeditor/ckeditor5-dev#704
Closed

Improve the list of manual tests and in-test navigation #9843

oleq opened this issue Jun 9, 2021 · 0 comments · Fixed by ckeditor/ckeditor5-dev#704
Assignees
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Jun 9, 2021

📝 Provide a description of the improvement

I noticed several issues with our manual tests and I propose several improvements:

There's no easy way to go back to the list of tests with the collapsed sidebar

ATM if you work with the collapsed sidebar (and we usually do because we use MTs as development sandboxes) you have to expand the sidebar and click the link. This is annoying and even more so on mobile devices. I propose a new button + the revamped toggle sidebar button:

Clicking a test on the list requires precision

If you open tests 5 times a day, that's OK. If you do this 200 times, things start to get annoying. I propose full-width links to tests with hover effect for clarity.

Test names in the list are cluttered

We use a RegExp to extract test names but it got neglected/forgotten (there are no tests for the list BTW) when new packages arrived in external/. And this results in:

which is ridiculous to look at and search in. I propose the new cleaner look of the list:


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. squad:platform Issue to be handled by the Platform team. package:dev labels Jun 9, 2021
@oleq oleq self-assigned this Jun 9, 2021
@oleq oleq added this to the iteration 44 milestone Jun 9, 2021
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Jun 10, 2021
…mplates

Other (tests): Added the always visible button that navigates back to the list of manual tests. Refined the look of the list of manual tests. Closes ckeditor/ckeditor5#9843.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant