Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl + A in the balloon doesn't select whole content #498

Closed
Mgsy opened this issue Jul 7, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-ui#295
Closed

Ctrl + A in the balloon doesn't select whole content #498

Mgsy opened this issue Jul 7, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-ui#295
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 12

Comments

@Mgsy
Copy link
Member

Mgsy commented Jul 7, 2017

Steps to reproduce

  1. Open the balloon (it could be the link balloon or the text alternative balloon).
  2. Focus the input.
  3. Press Ctrl + A.

Current result

Nothing happens.

GIF

bug_cke5

Other information

OS: Windows 10, MacOS X
Browser: Chrome, Safari, Firefox, Edge, Opera
@Mgsy Mgsy added the type:bug This issue reports a buggy (incorrect) behavior. label Jul 7, 2017
@Reinmar Reinmar added this to the iteration 12 milestone Jul 11, 2017
@oleq
Copy link
Member

oleq commented Aug 24, 2017

The problem is this line. It's been introduced to fix https://github.com/ckeditor/ckeditor5-link/issues/126 but when removed, I cannot reproduce the original issue anyway which is odd.

@Reinmar
Copy link
Member

Reinmar commented Aug 24, 2017 •
edited
Loading

So how do you know that it's this line? :D

@Reinmar
Copy link
Member

Reinmar commented Aug 24, 2017

Oh, by "original issue" you mean ckeditor/ckeditor5-link#126. Nvmnd

@oskarwrobel oskarwrobel mentioned this issue Sep 4, 2017
Merged
oleq added a commit to ckeditor/ckeditor5-ui that referenced this issue Sep 5, 2017
@oleq
Merge pull request #295 from ckeditor/t/294
e5315df 
Fix: The content of the `BalloonPanelView` should be selectable. Closes #294. Closes ckeditor/ckeditor5#498.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 12
Development

Successfully merging a pull request may close this issue.

Fix: Removed hacks from BalloonPanelView that made BalloonPanel unselectable ckeditor/ckeditor5-ui
3 participants
@Reinmar @oleq @Mgsy