Skip to content

Commit

Permalink
Merge pull request #12318 from ckeditor/ck/12277-color-button-unneces…
Browse files Browse the repository at this point in the history
…sary-tooltip

Fix (font): Removed an unnecessary tooltip for the "Remove color" button. Closes #12277.
  • Loading branch information
mlewand authored Aug 23, 2022
2 parents 037ac54 + 76ebb50 commit 6655e82
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion packages/ckeditor5-font/src/ui/colortableview.js
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@ export default class ColorTableView extends View {
buttonView.set( {
withText: true,
icon: icons.eraser,
tooltip: true,
label: this.removeButtonLabel
} );

Expand Down
3 changes: 1 addition & 2 deletions packages/ckeditor5-font/tests/ui/colortableview.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ describe( 'ColorTableView', () => {
expect( colorTableView.selectedColor ).to.equal( 'white' );
} );

it( 'should set tooltip for the remove color button', () => {
it( 'should set label for the remove color button', () => {
expect( colorTableView.removeButtonLabel ).to.equal( 'Remove color' );
} );

Expand Down Expand Up @@ -255,7 +255,6 @@ describe( 'ColorTableView', () => {
it( 'should have proper settings', () => {
expect( removeButton.withText ).to.be.true;
expect( removeButton.icon ).to.equal( removeButtonIcon );
expect( removeButton.tooltip ).to.be.true;
expect( removeButton.label ).to.equal( 'Remove color' );
} );

Expand Down

0 comments on commit 6655e82

Please sign in to comment.