Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Feature: Add option formKey configuration #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sg-brady
Copy link

Add optional configuration to change the form key used in the file upload. Currently simpleUploadAdapter uses the default form key upload. This change lets the user specify a key or, if none is specified, the default of upload is used.

Add optional configuration to change the form key used in the file upload. Currently `simpleUploadAdapter` uses the default form key `upload`. This change lets the user specify a key or, if none is specified, the default of `upload` is used.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.281% when pulling 244b04c on sg-brady:patch-1 into d0b6a52 on ckeditor:master.

@Reinmar
Copy link
Member

Reinmar commented Jan 2, 2020

Hi!

Thanks for the PR and sorry for really late reply.

The change makes sense. 

What we need to close it is:

  • documentation for the new option (here and here),
  • tests.

@Reinmar Reinmar self-assigned this Jan 2, 2020
Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants