This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Improved ContextualBalloon to deal with an async Views. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge after review because Link plugin needs to be aligned to this changes. |
oskarwrobel
commented
Apr 12, 2017
| this.view.content.add( view ); | ||
| this.view.attachTo( this._getBalloonPosition() ); | ||
| return this.view.content.add( view ).then( () => { | ||
| this.view.attachTo( this._getBalloonPosition() ); |
There was a problem hiding this comment.
This still logs errors on the browser console in synchronous tests because this.view.attachTo is called in the next event loop even when given view is ready.
|
|
|
Extra: |
|
Shouldn't |
|
Fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Improved ContextualBalloon to deal with an async Views. Closes ckeditor/ckeditor5#5340.
Related: ckeditor/ckeditor5-link#104