This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/191: Merged FloatingPanelView into BalloonPanelView #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lloonPanelView#unpin().
…ed tests to the new pin() API. Updated documentation.
control the visibility of the panel.
oskarwrobel
reviewed
Apr 10, 2017
| if ( this._pinWhenIsVisibleCallback ) { | ||
| // Deactivate listeners attached by pin(). | ||
| this.stopListening( global.document, 'scroll' ); | ||
| this.stopListening( global.window, 'resize' ); |
There was a problem hiding this comment.
You can use this._stopPinning()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Merged FloatingPanelView into BalloonPanelView. Closes ckeditor/ckeditor5#5334.
BREAKING CHANGE:
FloatingPanelViewis no longer available.BREAKING CHANGE:
BalloonPanelView#keepAttachedTohas been replaced bypin().BREAKING CHANGE: Default position names in
BalloonPanelView.defaultPositionshave changed. Now prefixed witharrow_.Requires ckeditor/ckeditor5-utils#147.