This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Introduced styles for LinkFormView
with manual decorators.
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
suggested changes
Jun 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unacceptable because in other languages this label could be long and people must be able to read it as a whole. The label should widen the form and the form should have some sane min-width.
cc @dkonopka
msamsel
force-pushed
the
t/ckeditor5-link/186
branch
from
June 24, 2019 09:26
abaea34
to
e93b428
Compare
@oleq Fixed. |
oleq
suggested changes
Jun 24, 2019
theme/ckeditor5-link/linkform.css
Outdated
* See: https://github.com/ckeditor/ckeditor5-link/issues/186. | ||
*/ | ||
.ck.ck-link-form_layout-vertical { | ||
display: block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes to ckeditor5-link/theme/linkform.css
.
…link URL input margins when decorators are on.
… background colors and shadows as a visual feedback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduced styles for
LinkFormView
with manual decorators. Closes https://github.com/ckeditor/ckeditor5-link/issues/186.Additional information
Required: ckeditor/ckeditor5-link#222