Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Introduced styles for LinkFormView with manual decorators. #233

Merged
merged 8 commits into from
Jun 25, 2019

Conversation

dkonopka
Copy link
Contributor

@dkonopka dkonopka commented Jun 13, 2019

Suggested merge commit message (convention)

Feature: Introduced styles for LinkFormView with manual decorators. Closes https://github.com/ckeditor/ckeditor5-link/issues/186.


Additional information

Required: ckeditor/ckeditor5-link#222

Screenshot 2019-06-13 at 13 48 16

Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is unacceptable because in other languages this label could be long and people must be able to read it as a whole. The label should widen the form and the form should have some sane min-width.

Screenshot 2019-06-19 at 14 16 21

cc @dkonopka

@msamsel msamsel force-pushed the t/ckeditor5-link/186 branch from abaea34 to e93b428 Compare June 24, 2019 09:26
@dkonopka
Copy link
Contributor Author

@oleq Fixed.

* See: https://github.com/ckeditor/ckeditor5-link/issues/186.
*/
.ck.ck-link-form_layout-vertical {
display: block;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes to ckeditor5-link/theme/linkform.css.

@dkonopka dkonopka requested a review from oleq June 25, 2019 13:06
oleq added 2 commits June 25, 2019 17:07
…link URL input margins when decorators are on.
… background colors and shadows as a visual feedback.
@oleq oleq merged commit b28d360 into master Jun 25, 2019
@oleq oleq deleted the t/ckeditor5-link/186 branch June 25, 2019 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting link's target attribute (allow opening links in new tabs)
2 participants