Schema tab #155
Merged
Schema tab #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
reviewed
May 4, 2022
There was a problem hiding this comment.
LGTM.
However, I see some fields for improvement.
Items listed in the "Schema / Inspect" pane behave like a link, but it is unclear where it points.
For instance, the SchemaCompiledItemDefinition text leads to the documentation, while definitions switch the inspected item.
WDYT about the following improvements?
- Use the
pointercursor while the mouse is over a definition? - Add the
[title]attribute that explains where it leads, e.g., "Click to see the $block definition."
Also, it would be good to add support for arrow keys. When pressing the down/up arrow, the "Inspect" view switches a definition to preview.
|
|
||
| if ( !definition ) { | ||
| return <Pane isEmpty="true"> | ||
| <p>Select a schema definition to inspect</p> |
There was a problem hiding this comment.
Suggested change
| <p>Select a schema definition to inspect</p> | |
| <p>Select a schema definition to inspect.</p> |
In the src/schema/pane.js file, a sentence ends with a dot.
|
After merging the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Introduced the schema tab. Closes #41.
Note: I realize this feature could be better. There could be better ways to visualize dependencies (as a foldable tree), browse attributes and filter the whole thing (gets busy when the editor has GHS). But my intention was to bring something (better than nothing) using UI components we already have and then we can iterate in MVP2. I also know that this should probably be under "Model" tab but because of the design decision we took years ago, there's no space (layout) for this kind of thing. It requires two panels, so it won't fit next to "Markers".