This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/1: Introduced Inline Editor #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactoring and minor improvements in manual test.
oleq
changed the title
Reinmar
reviewed
Mar 9, 2017
tests/inlineeditorui.js
Outdated
| import ClassicTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/classictesteditor'; | ||
|
|
||
| import FocusTracker from '@ckeditor/ckeditor5-utils/src/focustracker'; | ||
| import * as enableToolbarKeyboardFocus from '@ckeditor/ckeditor5-ui/src/toolbar/enabletoolbarkeyboardfocus'; |
There was a problem hiding this comment.
Didn't I comment on this in some other PR? I can't find it now ;| tl;dr was that this is unsafe.
There was a problem hiding this comment.
OK, I mistakenly merged the PR in editor-classic which has exactly the same issue: https://github.com/ckeditor/ckeditor5-editor-classic/pull/50/files/7377a8021ddf03236599622e9e768058e21df18f#r104738910. Please, fix both at the same time.
There was a problem hiding this comment.
Fixed directly in master of editor-classic ckeditor/ckeditor5-editor-classic@8b936cd.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed merge commit message
Feature: Introduced Inline Editor. Closes: ckeditor/ckeditor5#2250.