Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#628 Removed unnecessary scripts (used on Travis) #629

Merged
merged 2 commits into from
May 15, 2020
Merged

#628 Removed unnecessary scripts (used on Travis) #629

merged 2 commits into from
May 15, 2020

Conversation

pomek
Copy link
Member

@pomek pomek commented May 5, 2020

Suggested merge commit message (convention)

Other (tests): Removed unnecessary scripts after merging the main repository to the monorepo. Closes #628.


Additional information

I am not sure about BREAKING CHANGE note. We're removing files but they were created for CI purposes. Public API of any package didn't change but npm scripts from ckeditor5-dev-tests have been removed. Help needed.

@pomek pomek requested a review from mlewand May 5, 2020 09:10
@coveralls
Copy link

coveralls commented May 5, 2020

Coverage Status

Coverage decreased (-1.8%) to 89.311% when pulling e3def16 on i/628 into 24b718d on master.

Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good 👍

There's one mrgit mention remaining:

logDryRun( 'It will also work using mrgit: `mrgit exec "git clean -f"`' );
I'll remove this with a separate commit in a minute.

@mlewand
Copy link
Contributor

mlewand commented May 15, 2020

And agree that should be a major breaking change, we're removing a publicly available binaries. Given that we'll have other major BCs soon I don't think it's an issue for us.

@mlewand mlewand merged commit e2048e9 into master May 15, 2020
@mlewand mlewand deleted the i/628 branch May 15, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean after merging CKEditor 5 to monorepo
3 participants