Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recipe for nextjs #690

Merged
merged 2 commits into from
May 21, 2024
Merged

docs: recipe for nextjs #690

merged 2 commits into from
May 21, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented May 17, 2024

Description

Fixes #688

This PR added an example for working with Next.js

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation or Website

@homura homura requested review from Keith-CY and twhy May 17, 2024 05:08
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview May 21, 2024 6:35am

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (a1592dd) to head (86cdb17).
Report is 18 commits behind head on develop.

Current head 86cdb17 differs from pull request most recent head b73ff45

Please upload reports for the commit b73ff45 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #690      +/-   ##
===========================================
+ Coverage    84.30%   86.62%   +2.32%     
===========================================
  Files          121      126       +5     
  Lines        24574    25164     +590     
  Branches      2364     2698     +334     
===========================================
+ Hits         20717    21799    +1082     
+ Misses        3816     3328     -488     
+ Partials        41       37       -4     
Files Coverage Δ
packages/hd/src/xpub_store.ts 100.00% <100.00%> (+27.90%) ⬆️

... and 42 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a6fc2...b73ff45. Read the comment docs.

packages/hd/src/xpub_store.ts Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Member

This PR includes functional updates but the title starts with docs:, which will be misleading after merge.

@homura
Copy link
Collaborator Author

homura commented May 21, 2024

This PR includes functional updates but the title starts with docs:, which will be misleading after merge.

I've separated the codecov upgrade and dropped fs support for xpub store into other PRs

@homura homura merged commit 6e0d0e2 into develop May 21, 2024
7 checks passed
@homura homura deleted the nextjs-docs branch May 21, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add next.js in Docs/Receipts/CRA, Vite, Webpack or Other
3 participants