support modifying the resource download request #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVickery-TBS
pushed a commit
to JVickery-TBS/ckanext-xloader
that referenced
this pull request
Jun 19, 2023
QOLDEV-347 Prepare for CKAN 2.10
ThrawnCA
reviewed
Jan 29, 2024
| @@ -10,6 +10,19 @@ class IXloader(Interface): | |||
| The before_submit function, when implemented | |||
| """ | |||
|
|
|||
| def modify_download_request(self, url, resource, api_key, headers): | |||
| """ Can be used to modify the http download request. | |||
| The headers parameter is a dict which should be modified directly. | |||
There was a problem hiding this comment.
I think this should say "can be modified" rather than "should be modified".
|
@OriHoch This looks like it could proceed, but needs the merge conflict resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an IXLoader interface method: modify_download_request, which can be used to modify the download url or http headers.