Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor test improvements #288

Merged
merged 1 commit into from
May 9, 2017
Merged

Minor test improvements #288

merged 1 commit into from
May 9, 2017

Conversation

davidread
Copy link
Contributor

  • More explicit checks of the exception thrown when checking harvest config
  • The default_groups test was checking default_tags, so I fixed that (L274)

More explicit checks of the exception thrown when checking harvest co…
cc43878 
…nfig. Also the default_groups test was checking the wrong thing completely.
@amercader amercader merged commit de01277 into master May 9, 2017
@amercader amercader deleted the explicit_exception_checks branch May 9, 2017 10:55
@amercader
Copy link
Member

Thanks @davidread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amercader amercader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidread @amercader