Fix crash when exported requirements contain Poetry warnings #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjolowicz
force-pushed
the
fix-crash-for-stale-lockfiles
branch
from
b43c602
to
d6101a0
Compare
cjolowicz
force-pushed
the
fix-crash-for-stale-lockfiles
branch
from
d6101a0
to
7753920
Compare
cjolowicz
force-pushed
the
fix-crash-for-stale-lockfiles
branch
2 times, most recently
from
6a296c6
to
69ab716
Compare
cjolowicz
force-pushed
the
fix-crash-for-stale-lockfiles
branch
from
69ab716
to
911c8e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
Poetry.exporthelper to detect and remove warnings in the command output. Any warnings found are written to standard error, so the user can see them.Background: Poetry writes warnings to standard output when exporting the requirements. This results in a parse error from
packagingwhen it attempts to parse the warning as a requirement. A common case is the warning about an outdated lock file.Fixes #349