Fix crash when users run Nox with the new --no-install
option
#382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--no-install
option introduced in Nox 2021.6.6 means thatsession.run_always
can return None instead of the command output. This breaks assumptions nox-poetry makes when using itsPoetry
helper class to build a package or export a requirements file. Currently, this will lead to an assertion failure, and a cryptic error message.This PR fixes the behavior when
--no-install
is passed:session.install
orsession.poetry.installroot
, we skip all commands silently.session.poetry.export_requirements
orsession.poetry.build_package
, we cannot skip the command silently, because the function must return something. Instead, we raise an exception with a helpful message.