Skip to content

Commit

Permalink
src: fix -Winconsistent-missing-override warning
Browse files Browse the repository at this point in the history
Fix a compiler warning that was introduced in commit 4db1bc8
("http2: allocate on every chunk send") by adding an `override` keyword.

PR-URL: nodejs#16726
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
bnoordhuis authored and cjihrig committed Nov 7, 2017
1 parent b441573 commit da66610
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/node_http2.h
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ class Http2Session : public AsyncWrap,
const SubmitTrailers& submit_trailers) override;

void Send(WriteWrap* req, char* buf, size_t length) override;
WriteWrap* AllocateSend();
WriteWrap* AllocateSend() override;

int DoWrite(WriteWrap* w, uv_buf_t* bufs, size_t count,
uv_stream_t* send_handle) override;
Expand Down

0 comments on commit da66610

Please sign in to comment.