[Upgrade Assistant] Support completion state on overview page #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya!
This PR adds some of the remaining work for elastic#110737 in order to support for step completion for fix_logs and fix_issues steps, along with their respective tests. It's missing tests for cloud step since it seems there was a conflict along the way after your previous PR got merged.
I ended up removing the setIsCompleted from all the useEffects because when invoked the overview component gets re-rendered and the .bind functions passed to the steps definitions have a new fn instance. We either will have to memoize them or simply recur to ignore the setIsCompleted from the dependencies array.