Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude disk images with name containing "k3s" #58

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Conversation

zulh-civo
Copy link
Member

Closes #57

@zulh-civo zulh-civo self-assigned this Aug 19, 2021
@zulh-civo zulh-civo requested a review from alejandrojnm August 19, 2021 09:11
disk_image_test.go Outdated Show resolved Hide resolved
@zulh-civo zulh-civo requested a review from andyjeffries August 19, 2021 09:21
@andyjeffries
Copy link
Contributor

LGTM

@zulh-civo
Copy link
Member Author

Will you merge? Or me?

@andyjeffries
Copy link
Contributor

You please. I think the way we should be doing PRs is if a Civo staff member raises it, someone else approves it but it's up to the originator to merge it. If it's an externally raised MR then the Civo staff member approving merges it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter down Disk Images to only compute/instance operating systems
2 participants