Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont't work in Europe #69

Open
olivierh65 opened this issue Dec 23, 2018 · 5 comments
Open

Dont't work in Europe #69

olivierh65 opened this issue Dec 23, 2018 · 5 comments

Comments

@olivierh65
Copy link

Hi,
Sparkpost use a eu.sparkpost.com for European users.
Replacing all URLs https://sparkpost.com by https://.eu.sparkpost.com allow the plugin to works fine.

It will be nice to add an option to define the URL (sparkpost.com or eu.sparkpost.com

Regards.

@nganivet
Copy link
Contributor

@olivierh65 Can you fund this improvement? We can do that for 300 Euros. Thanks.

@olivierh65
Copy link
Author

olivierh65 commented Dec 27, 2018 via email

@herbdool
Copy link
Contributor

@nganivet I've cleaned up the PR here #86. I've improved the code syntax, labels and removed the tracking setting since that's better off in a new issue.

Please review and let me know if it needs tweaking or if it can be merged. Thanks for your help on this.

@herbdool
Copy link
Contributor

@nganivet thanks for merging. Would you be able to create a new release? It's been a couple years and 16 commits since the last release.

@herbdool
Copy link
Contributor

I believe this issue can closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants