Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#467] Added multi-line header option. #506

Open
wants to merge 9 commits into
base: feature/447-primary-nav
Choose a base branch
from

Conversation

febdao
Copy link
Collaborator

@febdao febdao commented Mar 6, 2025

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Added multi-line option for header.

Screenshots

Screenshot 2025-03-07 at 12 09 32 am
Screenshot 2025-03-07 at 12 09 07 am

Copy link

github-actions bot commented Mar 6, 2025

@github-actions github-actions bot temporarily deployed to pull request March 6, 2025 13:18 Inactive
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.09%. Comparing base (13e708b) to head (1214377).
Report is 10 commits behind head on feature/447-primary-nav.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/447-primary-nav     #506      +/-   ##
===========================================================
+ Coverage                    12.64%   13.09%   +0.45%     
===========================================================
  Files                           36       20      -16     
  Lines                         1131     1092      -39     
  Branches                       256      228      -28     
===========================================================
  Hits                           143      143              
+ Misses                         798      774      -24     
+ Partials                       190      175      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@febdao febdao requested a review from alan-cole March 9, 2025 13:03
@febdao febdao added PR: Needs review Pull request needs a review from assigned developers BLOCKED Issue or pull request is blocked labels Mar 9, 2025
@github-actions github-actions bot temporarily deployed to pull request March 9, 2025 13:04 Inactive
@febdao febdao changed the base branch from main to feature/447-primary-nav March 9, 2025 13:04
@febdao
Copy link
Collaborator Author

febdao commented Mar 9, 2025

Hi @alan-cole
This pull request need the code from #481 for the navigation updated but it's still ready for CR.
Please review it and merge it after #481 is merged.
Cheers,

Copy link
Collaborator

@alan-cole alan-cole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put this one on hold for now. We need design to provide more guidance on how and what should be supported in header.

@richardgaunt richardgaunt added PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request 1.11 labels Mar 19, 2025
@richardgaunt richardgaunt added this to the 1.11 milestone Mar 19, 2025
@richardgaunt richardgaunt removed the 1.11 label Mar 19, 2025
@febdao febdao removed the PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request label Mar 20, 2025
@github-actions github-actions bot temporarily deployed to pull request March 20, 2025 03:43 Inactive
@febdao febdao marked this pull request as draft March 20, 2025 04:31
@github-actions github-actions bot temporarily deployed to pull request March 20, 2025 05:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 21, 2025 01:46 Inactive
@febdao febdao requested a review from alan-cole March 21, 2025 01:54
@febdao febdao marked this pull request as ready for review March 21, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED Issue or pull request is blocked PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants