-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#467] Added multi-line header option. #506
base: feature/447-primary-nav
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/447-primary-nav #506 +/- ##
===========================================================
+ Coverage 12.64% 13.09% +0.45%
===========================================================
Files 36 20 -16
Lines 1131 1092 -39
Branches 256 228 -28
===========================================================
Hits 143 143
+ Misses 798 774 -24
+ Partials 190 175 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @alan-cole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put this one on hold for now. We need design to provide more guidance on how and what should be supported in header.
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.
Changed
section about WHY something wasdone if this was a bespoke implementation.
and they have passed.
Changed
Screenshots