This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
(mosaico#247) (dev/core#588) Apply prefix to subject of test mailings #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is was previously fixed in civicrm/civicrm-core#12758, but that fix had a couple undesired side-effect: * For non-Mosaico mailings, the prefix would be applied twice (https://lab.civicrm.org/dev/core/issues/588); once in the JS layer and once in the BAO delivery engine. * The saved value of the `subject` would temporarily store the prefix as part of the subject. (In normal usage, it would be fixed later by an autosave; but there could be edge-cases/races.) This is an alternative fix which makes flexmailer more precisely imitate the behavior in the BAO delivery engine. Note: If one doesn't like this behavior, then you can disable or replace the service, e.g. ```php Civi::service('civi_flexmailer_test_prefix')->setActive(FALSE); ```
|
I've
|
| <?php | ||
| /* | ||
| +--------------------------------------------------------------------+ | ||
| | CiviCRM version 4.7 | |
There was a problem hiding this comment.
@totten nitpcik this should be civicrm 5 and copyright to 2018
There was a problem hiding this comment.
Yup. The copyright header should be changed. I'm inclined to do that a separate PR with a global search/replace.
|
@totten i have merged the other PR so i think this is good now |
|
/test |
|
Thanks, @seamuslee001. Tests have passed here. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is was previously fixed in civicrm/civicrm-core#12758, but that fix had a
couple undesired side-effect:
once in the JS layer and once in the BAO delivery engine.
subjectwould temporarily store the prefix as part of the subject.(In normal usage, it would be fixed later by an autosave; but there could be edge-cases/races.)
This is an alternative fix which makes flexmailer more precisely imitate the
behavior in the BAO delivery engine.
Note: If one doesn't like this behavior, then you can disable or replace the service, e.g.