Fix access permissions for sub-pages and "Quick Add" dashlet #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have done multiple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes this issue on Lab.
Before
Incorrect capabilities are assigned to Settings (and currently-disabled Integration) sub-pages and the "Quick Add" dashlet.
After
More appropriate capabilities are assigned to Settings (and currently-disabled Integration) sub-pages and the "Quick Add" dashlet.
Technical Details
As noted on the issue,
manage_optionsseems a more sensible default capability thanadminister_civicrmfor the sub-pages becauseadminister_civicrmis not automatically granted to WordPress admins. I have added a filter for each page so that this can be overridden if required.The "Quick Add" dashlet queries CiviCRM directly for the
add_contactspermission because the permission may or may not have been granted to the WordPress User and thereforecurrent_user_can()can't necessarily determine the User's status.