Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure "civicrm_initialized" action only fires once #221

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

christianwach
Copy link
Member

Overview

At present, the civicrm_initialized action fires every time civi_wp()->initialize() is called. This should only happen once.

Before

The civicrm_initialized action fires every time civi_wp()->initialize() is called.

After

The civicrm_initialized action fires only when civi_wp()->initialize() actually initialises CiviCRM.

Technical Details

Code that listens for the civicrm_initialized action receives callbacks every time civi_wp()->initialize() is called. This appears to have been an error on my part when refactoring for CiviCRM 4.6. This PR implements the intended behaviour.

@kcristiano
Copy link
Member

I have done an r-run on master with this PR applied.

Install is fine, CiviCRM itself is good. The usual set of plugins I use run as expected.

The change is an improvement. If there are any plugins/extensions that are affected we'll flush them out during the RC period.

@kcristiano kcristiano merged commit e8b939d into civicrm:master Nov 23, 2020
@christianwach christianwach deleted the init-action branch November 23, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants