Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "page=CiviCRM" query string from WordPress front-end (5.26) #194

Merged
merged 1 commit into from
May 20, 2020

Conversation

christianwach
Copy link
Member

@christianwach christianwach commented May 18, 2020

Overview

Additional PR against 5.26 branch. Same fix as #193. Requires this PR on CiviCRM Core. Solves this issue on Lab.

@christianwach christianwach changed the title Remove "page=CiviCRM" query string from WordPress front-end Remove "page=CiviCRM" query string from WordPress front-end (5.26) May 18, 2020
@kcristiano
Copy link
Member

@christianwach
Copy link
Member Author

Force pushed a minor tweak that prevents endless redirects in certain edge cases. FWIW, this could be related to opcache or similar preserving page=CiviCRM as a query var despite the upgrade. Since the tweak works, I didn't delve too deeply.

@kcristiano
Copy link
Member

Merge Ready but needs to be merged at same time as civicrm/civicrm-core#17352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants