Set "cms.root" URL in addition to Path #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The code in
Civi::Paths::getVariable()
does not ensure all attributes of a named variable are set, so partially setting the attributes ofcms.root
sometimes causes "Cannot resolve path using 'cms.root.url'" exceptions to be thrown. This is relatively obscure because it requires a particular WordPress Multisite setup to occur, but the effect is repeatable.Before
"Cannot resolve path using 'cms.root.url'" exceptions are thrown. "Settings - Resource URLs" screen renders incorrectly in WordPress Multisite on a Subsite:
After
"Cannot resolve path using 'cms.root.url'" exceptions are not thrown. "Settings - Resource URLs" screen renders correctly in WordPress Multisite on a Subsite.
Technical Details
This PR is necessary because of an incomplete check for the existence of all attributes in Paths.php. Having said that, it's still better to assign both attributes early than have
Civi::Paths::getVariable()
recalculate them later.