Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcodes for Personal Campaign Pages #185

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Mar 5, 2020

Overview

Requires civicrm/civicrm-core#16695. This is the UI part that allows selecting Personal Campaign Pages when editing a page in wordpress.

Before

No personal campaign pages via shortcodes.

After

Personal campaign pages via shortcodes.

Technical Details

Comments

Ping @christianwach @kcristiano

@christianwach
Copy link
Member

@mattwire Thanks for this. Definitely nice to allow manual composition of an appropriate PCP shortcode in WordPress. However, doesn't it also require additional code in CiviCRM Core so that the PCPs appear in the CiviCRM popup?

https://github.com/civicrm/civicrm-core/search?q=shortcode&unscoped_q=shortcode

@mattwire
Copy link
Contributor Author

mattwire commented Mar 9, 2020

@mattwire Thanks for this. Definitely nice to allow manual composition of an appropriate PCP shortcode in WordPress. However, doesn't it also require additional code in CiviCRM Core so that the PCPs appear in the CiviCRM popup?

It does... this covers it? civicrm/civicrm-core#16695

@christianwach
Copy link
Member

@mattwire Ah dang it. Must have coffee before looking at PRs!

@christianwach
Copy link
Member

@kcristiano I've tested this in the absence of civicrm/civicrm-core#16695 and it allows PCP Shortcodes to be rendered when manually constructed, e.g.

[civicrm component="pcp" id="1" mode="live" hijack="0"]

When the code in @mattwire's PR to CiviCRM Core becomes available, then the popover will enable selection of PCPs via the UI. I say we merge this as is.

@kcristiano
Copy link
Member

kcristiano commented Mar 12, 2020

@christianwach I've done an r-run with civicrm/civicrm-core#16695 and it works as described.

This will create a single PCP page via shortcode. The next logical question is how do we show an 'archive' page listing all PCP pages.

@christianwach christianwach merged commit 31e55ba into civicrm:master Mar 12, 2020
@mattwire mattwire deleted the pcpshortcodes branch April 6, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants