Do not render shortcodes in PUT, POST or DELETE

[bastienho]

Overview

A correction for #129
Do not render shortcodes in REST context for PUT, POST and DELETE methods

Before

REST calls (eg: in gutenberg editor) using PUT, POST or DELETE methods are resulting on an exception.

After

Shortcode is returned unrendered, as it.

Technical details

The exception is provided by CRM_Core_Controller

Comments

WordPress REST API output contain both rendered and raw content, so it seems to be cleaner to render the shortcode.

It would be nicer to update CiviCRM core in order to hook into CRM_Core_Controller to let adding page_arguments[ignoreKey]=true in request args.

Forcing ignoreKey to true correctly renders the shortcode.

[kcristiano]

@bastienho Can you look at the conflicts in this file? Perhaps rebase so we can move this forward?

[kcristiano]

kcristiano@243a11b is rebased against master. The code looks good, you have limited where it is being called and testing it has caused no errors for me.

[kcristiano]

@haystack Any objections to the latest PR? I would like to gte this in early in the RC cycle and I believe 5.3-RC is about a week away

I have been testing against master and it works well.

• (r-explain) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass: Tested against WP 4.9.6 and CiviCRM master branch
• (r-user) Pass
• (r-tech) Pass

[kcristiano]

@christianwach Can you add your review on this I have moved this patch to productionon our 5.x sites and have had good results, I'd like to see this in sooner rather than later

cc @eileenmcnaughton

[christianwach]

@kcristiano Looks okay to me

[christianwach]

@bastienho Could you squash these commits into a single one please?

[bastienho]

@christianwach done.

[eileenmcnaughton]

@christianwach @kcristiano shall I merge?

[kcristiano]

@eileenmcnaughton yes please and thank you