Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php 7.2 fix notice on countable #229

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Php 7.2 fix notice on countable #229

merged 1 commit into from
Nov 15, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Fixes php 7.2 enotice by checking for NULL before attempting to count

screenshot 2018-11-15 11 29 06

@civibot
Copy link

civibot bot commented Nov 14, 2018

(Standard links)

@civibot civibot bot added the master label Nov 14, 2018
@colemanw
Copy link
Member

Test failure unrelated. Looks like a no-brainer- you can't count NULL.

@colemanw colemanw merged commit 63801c3 into civicrm:master Nov 15, 2018
@eileenmcnaughton eileenmcnaughton deleted the php72 branch November 15, 2018 02:03
wmfgerrit pushed a commit to wikimedia/wikimedia-fundraising-crm that referenced this pull request Dec 18, 2018
@eileenmcnaughton
CiviCRM submodule commit
f5ee196 
+ 417686bd867eb4516bea1c283fe56d502af074d1 PHP 7.3 fix, merged upstream
+ 1b41202f8061d1f2eff8b5f3a860ca5c6c669bae Php 7.2 fix civicrm/civicrm-packages#229

Change-Id: I9fc5d5f8650143bc6d98a51018d12ff03662a97d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw