Strip trailing whitespace in quickform package #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a situation where we have a proposed change (from @monishdeb ) that is hard to read because of the trailing spaces being stripped - this is hard to avoid for anyone using an IDE or decent editor since trailing whitespaces are against our standard.
OTOH the upstream QF package is basically dead so we don't gain from keeping in sync with it.
It is easier to review this if you add w=1 to the url - ie. https://github.com/civicrm/civicrm-packages/compare/master...eileenmcnaughton:white?expand=1&w=1
This is not a full whitespace tidy up - in fact line endings are still set to windows :-(
But, by stripping the trailing ones we make legible PRs much more possible