Respect CIVICRM_DSN and CIVICRM_UF_DSN being different on upgrade #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisgaraffa - could you resolve the conflicts please |
|
Thanks for the ping @aydun! Just merged in the latest changes and reconfigured my work to use Civi\Setup now. |
|
This seems fine to me thanks @chrisgaraffa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://lab.civicrm.org/dev/joomla/-/issues/47 - When CIVICRM_UF_DSN and CIVICRM_DSN point to different databases, the upgrade process does not respect that and defaults to using the Joomla database.
Tested on Joomla 3.10.11 and 4.2.9.