Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views - CiviGrant is now an extension #654

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 8, 2022

PR for 5.48
See #653

@civibot
Copy link

civibot bot commented Mar 8, 2022

(Standard links)

@seamuslee001
Copy link
Contributor

Jenkins retest this please

@demeritcowboy
Copy link
Contributor

I had some issues with civicrm_queue after the patch but I think they're unrelated. Will sort that out later. But this doesn't seem to fix the problem but I don't know why yet.

BEFORE

  1. Set up drupal with views (single-db so don't have to deal with that).
  2. Enable civigrant component.
  3. Make some grants.
  4. Make a view that shows some grants.
  5. Upgrade - progress bar hangs. Error class CRM_Grant_DAO_Grant not found.
  6. Grant extension appears disabled.

AFTER

  1. Upgrade - progress bar hangs. Error class CRM_Grant_DAO_Grant not found.
  2. Grant extension appears disabled.

@colemanw
Copy link
Member Author

colemanw commented Mar 8, 2022

Thanks @demeritcowboy this PR isn't actually intended to address that upgrade problem, but to allow views of grants to continue working normally, post-upgrade.

I'm trying to recreate the upgrade problem locally and if I manage to do that then I'll work through it with a debugger.

@demeritcowboy
Copy link
Contributor

Ok I think I see what my problem is. If I test things like a dev instead of a sysadmin then it upgrades fine, but either way not related to this PR. I'll write that up in a ticket later since it might be more of a thing now.

@demeritcowboy demeritcowboy merged commit 36087c3 into civicrm:7.x-5.48 Mar 8, 2022
@colemanw colemanw deleted the civiGrant branch March 9, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants