Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow filtering by empty event end, registration start, registration … #634

Conversation

MegaphoneJon
Copy link
Contributor

…end dates

Of the date fields on civicrm_event - start date, end date, registration start date, registration end date - only "start date" is required. However, Views can't search for empty dates without explicitly specifying a date can be empty. This adds that specification to the three event dates that aren't required.

@civibot
Copy link

civibot bot commented Dec 9, 2020

(Standard links)

@civibot civibot bot added the 7.x-master label Dec 9, 2020
@eileenmcnaughton
Copy link
Contributor

@jitendrapurohit @petednz - is this one you could review?

@jitendrapurohit
Copy link
Contributor

BEFORE -

No filter to specify date = empty.

image

AFTER

Can be filtered with date=empty

image

The condition also works fine in rendering the results -

WHERE (( (civicrm_event.registration_start_date IS NULL ) AND (civicrm_event.end_date IS NOT NULL ) ))

@eileenmcnaughton eileenmcnaughton merged commit cf9c548 into civicrm:7.x-master Feb 3, 2021
@eileenmcnaughton
Copy link
Contributor

Thanks for the speedy review @jitendrapurohit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants