Advice in failure message is out of date #633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #624
If you try to r-run to see the message that was updated in that PR, you can't do it by having an incorrect civicrm_root as the message suggests. Probably that was true at one time but now if civicrm_root is wrong it doesn't even get this far to see the message, so the advice should be more on point about what failed.
I considered removing the entire reference to civicrm_root since it might lead them astray, but at least the main reason is stated now.
Drupal 8 has the same problem - see civicrm/civicrm-drupal-8#48
FYI @MikeyMJCO