Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice in failure message is out of date #633

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

demeritcowboy
Copy link
Contributor

Follow on to #624

If you try to r-run to see the message that was updated in that PR, you can't do it by having an incorrect civicrm_root as the message suggests. Probably that was true at one time but now if civicrm_root is wrong it doesn't even get this far to see the message, so the advice should be more on point about what failed.

I considered removing the entire reference to civicrm_root since it might lead them astray, but at least the main reason is stated now.

Drupal 8 has the same problem - see civicrm/civicrm-drupal-8#48

FYI @MikeyMJCO

@civibot
Copy link

civibot bot commented Dec 5, 2020

(Standard links)

@civibot civibot bot added the 7.x-master label Dec 5, 2020
@eileenmcnaughton eileenmcnaughton merged commit 9dfd680 into civicrm:7.x-master Feb 3, 2021
@demeritcowboy demeritcowboy deleted the old-message branch February 3, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants