CIVICRM-984: Make "Add CiviCRM Tag to Contact" action list tags #549
Conversation
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
Jenkins add to whitelist |
| return array(); | ||
| } | ||
| $result = civicrm_api3('tag', 'get', array( | ||
| 'used_for' => 'civicrm_contact', |
There was a problem hiding this comment.
@agileware-fj Francis the indenting looks off here
There was a problem hiding this comment.
@seamuslee001 I can't actually see a definitive answer on how this should be handled for function arguments in either the Drupal or CiviCRM coding standards.
Anyway, I've changed this to indent by 2 spaces for the arrays' contents only.
| * Options list callback for listing of CiviCRM Tags | ||
| */ | ||
| function civicrm_rules_tags_list() { | ||
| if(!civicrm_initialize()) { |
There was a problem hiding this comment.
@agileware-fj need a space after the if
| ) | ||
| )); | ||
| $values = array(); | ||
| foreach($result['values'] as $tag) { |
There was a problem hiding this comment.
@agileware-fj need a space after the foreach
agileware-fj
force-pushed
the
CIVICRM-984
branch
from
c2e0567 to
5b00ee9
Compare
|
jenkins, test this please |
|
@jackrabbithanna you know stuff about CiviRules does this make sense to you? |
|
Fixes a bug? Yes Should be OK to merge then. |
|
@agileware-justin Does that mean you've tested it and it's working? ;-) - if yes, I'll merge |
|
@mattwire worked in 2018 and still works in 2020.
|
|
Merging based on @agileware-justin comments/review |
Overview
This corrects the Admin UI of the "Add CiviCRM Tag to Contact" Rules action.
Before
"Add CiviCRM Tag to Contact" lists Groups to be added, but operates on Tag ID same as the selected group.
After
"Add CiviCRM Tag to Contact" lists Tags. No change to operation of the action.