dev/drupal#31 - CiviMember Role sync is no longer syncing Pending mem… #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spencerbrooks @agh1 either of you interested in reviewing this? |
|
I'm pretty bandwidth-constrained with running my agency these days so I need to pass. @agh1? |
|
This is working fine for us - and very necessary. |
|
merging based on testing by @dyguk - the code also looks pretty sensible & safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…berships
To reproduce -
ADD WHEN STATUS ISset toPending.Before changes - Role is not assigned.
After changes - Role is assigned correctly.
Gitlab Issue - https://lab.civicrm.org/dev/drupal/issues/31