Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix from D7 module. #514

Conversation

universalhandle
Copy link
Contributor

Replaces extremely inefficient (and inappropriate) API call for group_contact with one for group entity.

Replaces extremely inefficient (and inappropriate) API call for group_contact with one for group entity.
@universalhandle
Copy link
Contributor Author

@jackrabbithanna: here's some more D6 action for you.

Jenkins says there was one failing check, but I don't see any in the report and the console says:

PR test not allowed for 6.x-master

... so I guess human review will have to do.

@jackrabbithanna
Copy link
Contributor

Jenkins please retest this

@jackrabbithanna
Copy link
Contributor

Jenkins test this please

@jackrabbithanna
Copy link
Contributor

oh yeah I forgot d6 and d8 don't have tests. I've reviewed and tested the code.
Recommend Merging

@jackrabbithanna
Copy link
Contributor

Merging #514

@jackrabbithanna jackrabbithanna merged commit 1cfcb49 into civicrm:6.x-master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants