CRM-21371 - An api error when calling drush cvapi should be treated a… #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
7.x-master
branch
from
9f16b2a to
198b5a0
Compare
…s a drush error Also defines a used var and removes legacy svn id refs
eileenmcnaughton
force-pushed
the
7.x-master
branch
from
198b5a0 to
801b2a8
Compare
|
My only concern here is that failing api calls will become 'chattier' and people may have been making use of their existing tendency to fail quietly |
|
@mlutfy are you up to merge this - @jmcclelland tested it & commented on JIRA so it has already had some review (I would also contend it's low risk - although I guess there is the question of whether new 'chattiness' would upset some people?) |
|
I did a bit of testing and seems good to me. I agree with Jamie, the exit code is probably one of the best parts of this. |
|
Right - it was the lack of exit code that caused me to dig into it |
|
(we weren't noticing fails) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s a drush error
Also removes an unused var & defines a used var