-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update civicrm.core.inc #382
Conversation
There are some minor issues here with code formatting - particuarly comments and whitespace. Check https://www.drupal.org/coding-standards |
Reviewed this and changed the field that identifies the file_id Also , this seems to implicitly link an attachment to activities only. I don't think this would work for any attachments to entities other than activities |
@callosal as Release Manager this month, I'm trying to recruit people to help pare down the backlog of almost 100 PRs, some going back to last summer. I'm wondering if you would be able to help QA another PR if I got someone to QA this PR? |
@callosal Is there any Jira (https://issues.civicrm.org/jira/issues) ticket for it ? If not can you create one ? coz this is a nice improvement and should be tracked. |
Jenkins test this please |
Can one of the admins verify this patch? |
Since this stalled a long time back I'm closing to track in gitlab https://lab.civicrm.org/dev/drupal/-/issues/154 |
updated from http://civicrm.stackexchange.com/questions/741/how-do-i-add-civicrm-activity-attachment-to-view/11162?noredirect=1#comment11361_11162
first effort at this so may not be perfect