Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update civicrm.core.inc #382

Closed
wants to merge 4 commits into from
Closed

Conversation

callosal
Copy link

@callosal callosal commented May 6, 2016

@colemanw
Copy link
Member

colemanw commented May 7, 2016

There are some minor issues here with code formatting - particuarly comments and whitespace. Check https://www.drupal.org/coding-standards

@callosal
Copy link
Author

Reviewed this and changed the field that identifies the file_id

Also , this seems to implicitly link an attachment to activities only. I don't think this would work for any attachments to entities other than activities

@JoeMurray
Copy link

@callosal as Release Manager this month, I'm trying to recruit people to help pare down the backlog of almost 100 PRs, some going back to last summer. I'm wondering if you would be able to help QA another PR if I got someone to QA this PR?

@monishdeb
Copy link
Member

monishdeb commented Nov 3, 2016

@callosal Is there any Jira (https://issues.civicrm.org/jira/issues) ticket for it ? If not can you create one ? coz this is a nice improvement and should be tracked.

@seamuslee001
Copy link
Contributor

Jenkins test this please

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@eileenmcnaughton
Copy link
Contributor

Since this stalled a long time back I'm closing to track in gitlab https://lab.civicrm.org/dev/drupal/-/issues/154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants