Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Create hook_civicrm_alterAngular.md #524

Merged
merged 4 commits into from
Apr 23, 2018
Merged

Conversation

colemanw
Copy link
Member

See civicrm/civicrm-core#10085
@totten I've added docs for this hook.

@totten
Copy link
Member

totten commented Apr 20, 2018

Good idea adding a page under "Hooks".

FWIW, there's also this page: https://docs.civicrm.org/dev/en/latest/framework/angular/changeset/

At the moment, the pages are pretty similar, but the ambition in framework/angular/changeset was to also talk about the workflow with the helper commands

cv ang:html:list
cv ang:html:show <file>
cv ang:html:show <file> --diff

@totten
Copy link
Member

totten commented Apr 20, 2018

@colemanw I suggest hyperlinking between the pages and then merging.

@seancolsen
Copy link
Contributor

@colemanw also run ./bin/hook-summary.py to re-generate the hooks summary page based on the content of your hook file.

@colemanw colemanw force-pushed the hook_civicrm_alterAngular branch from 8e56c4d to 8558fef Compare April 22, 2018 19:12
@colemanw
Copy link
Member Author

@seanmadsen I've updated the pages per @totten's suggestion. Could you please check to see if I did the hyperlinks correctly?
I tried running the python script but it didn't do anything. It ran but gave no output and did not update the summary.md file :/ Might be a problem with python on my system?

@seancolsen
Copy link
Contributor

@colemanw

the python script but it didn't do anything

That's because the hook needed to be added to the menu (mkdocs.yml) first. (The python script reads from the menu file to generate the page.)

I modified the menu to add the hook. I also tweaked the hook description and regenerated the summary page. I think we're good to go here, so I'm merging.

@seancolsen seancolsen merged commit 65ecd6a into master Apr 23, 2018
@totten totten deleted the hook_civicrm_alterAngular branch April 24, 2018 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants