-
Notifications
You must be signed in to change notification settings - Fork 124
CRM-20600 - Add chapters for AngularJS and AssetBuilder #172
Conversation
@totten I see that civicrm/civicrm-core#10085 has now been merged. I'd like to get this content into the Dev Guide because it looks really useful. Is there more work to do here? |
mkdocs.yml
Outdated
@@ -57,6 +57,13 @@ pages: | |||
- Troubleshooting: extensions/troubleshooting.md # page-tree = DONE | |||
- Advanced patterns: extensions/advanced.md | |||
- Framework Reference: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose changing this section to the following:
- AngularJS:
- AngularJS: framework/angular/index.md
- AngularJS Quick Start: framework/angular/quickstart.md
- AngularJS File Names: framework/angular/files.md
- AngularJS Loader: framework/angular/loader.md
- AngularJS Modifications: framework/angular/modify.md
Reasons:
- Use
index.md
for hackable URLs (This change also requires a file rename) - Use more descriptive menu item labels (as described here, so that the
<title>
element better reflects the page content).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased (to address merge-conflits) and updated to use this structure.
Note: I also renamed "Modifications" to "Changesets". This matches terminology that is used in the code, and it feels a bit more precise.
docs/framework/angular.md
Outdated
about the internals of AngularJS 1.x or APIv3. You should be able to follow | ||
the discussion if you have a beginner-level understanding of both. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose removing this "Additional pages" section because it's a duplication of the listing of pages in the menu and thus is prone to falling out of sync if we add/remove/re-order these pages.
cc7f27b
to
7c1677a
Compare
I've removed the "WIP" label. Most sections should be presentable. I don't have a strong opinion on whether to merge now or to wait a bit. There is one page ( |
Exciting! This stuff looks really good. I have a couple follow-up points for which I'll create tickets. |
Depends: civicrm/civicrm-core#10085