Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19715 (IIDA-96), removed settings related to close accounting period and mo… #9983

Merged
merged 1 commit into from
Mar 15, 2017

Conversation

pradpnayak
Copy link
Contributor

…ved to an extension


…ved to an extension

----------------------------------------
* CRM-19715: Remove Close Accounting Period code
  https://issues.civicrm.org/jira/browse/CRM-19715
@pradpnayak
Copy link
Contributor Author

This PR contains code removal that was implemented part of CRM-16189 i.e Contribute Settings for Close Accounting Period which is now moved into an extension.

@pradpnayak pradpnayak changed the title CRM-19715, removed settings related to close accounting period and mo… CRM-19715 (IIDA-96), removed settings related to close accounting period and mo… Mar 15, 2017
@eileenmcnaughton
Copy link
Contributor

I'm happy to merge this, @pradpnayak earlier explained that the fiscalYear setting was duplicated on that form & remains on the date settings form.

However, there is still one more place I found that needs to go - that can be a follow up

//CRM-16189
if (CRM_Contribute_BAO_Contribution::checkContributeSettings('financial_account_bal_enable')) {
  $this->add('text', 'opening_balance', ts('Opening Balance'), $attributes['opening_balance']);
  $this->add('text', 'current_period_opening_balance', ts('Current Period Opening Balance'), $attributes['current_period_opening_balance']);
  $financialAccountType = CRM_Core_PseudoConstant::get(
    'CRM_Financial_DAO_FinancialAccount',
    'financial_account_type_id',
    array('labelColumn' => 'name')
  );

@eileenmcnaughton eileenmcnaughton merged commit f49761f into civicrm:master Mar 15, 2017
@pradpnayak pradpnayak deleted the CRM-19715-3 branch March 15, 2017 11:38
monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
CRM-19715 (IIDA-96), removed settings related to close accounting period and mo…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants