Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20270 - composer.lock - Fix multibyte warnings by updating ezcMail #9982

Merged
merged 1 commit into from
Mar 15, 2017

Conversation

totten
Copy link
Member

@totten totten commented Mar 14, 2017

On many systems, the test suite outputs a long message which begins with:

PHP Warning: declare(encoding=...) ignored because Zend multibyte feature is turned off by settings in /path/to/sites/all/modules/civicrm/vendor/zetacomponents/mail/src/transports/variable/var_set.php on line 2

This patch addresses the warning by updating the version of ezcMail (aka zetacomponents/mail). See also:

Possible interested parties: @mollux @xurizaemon @tschuettler @bgm


On many systems, the test suite outputs a long message which begins with:

```
PHP Warning: declare(encoding=...) ignored because Zend multibyte feature is turned off by settings in /path/to/sites/all/modules/civicrm/vendor/zetacomponents/mail/src/transports/variable/var_set.php on line 2
```

This patch addresses the warning by updating the version of ezcMail (aka `zetacomponents/mail`).  See also:

 * civicrm/zetacomponents-mail#1
 * http://civicrm.stackexchange.com/questions/16314/does-civicrm-have-a-recommended-setting-for-zend-multibyte
@seamuslee001
Copy link
Contributor

@totten don't you need to update composer.json as well?

@totten
Copy link
Member Author

totten commented Mar 15, 2017

@seamuslee001 The composer.json points to a branch (1.7-civi). If it pointed to a specific commit or version number, then we'd need to update it. As it stands, the only reference to the specific commit/version is in the composer.lock.

@seamuslee001
Copy link
Contributor

thanks for the explanation Tim, Makes sense to me then

@eileenmcnaughton
Copy link
Contributor

Yeah, let's do it, I hate that error. A minor package version update sounds safe enough....

@totten totten merged commit c8e462a into civicrm:master Mar 15, 2017
@totten totten deleted the master-zetamail branch March 15, 2017 21:22
monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
CRM-20270 - composer.lock - Fix multibyte warnings by updating ezcMail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants