Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-19469 support returning payment params after mapping #9973

Merged
merged 1 commit into from
Aug 29, 2017
Merged

CRM-19469 support returning payment params after mapping #9973

merged 1 commit into from
Aug 29, 2017

Conversation

lcdservices
Copy link
Contributor

@lcdservices lcdservices commented Mar 13, 2017 •
edited by civicrm-builder
Loading

@seamuslee001
Copy link
Contributor

@eileenmcnaughton any thoughts on this?

@eileenmcnaughton
Copy link
Contributor

I guess it's harmless but I don't like this comment

//CRM-19469 provide option for returning modified params

feels like 'I'm relying on a comment to prevent someone from breaking my code'

Still I'm going to merge & 'strongly encourage' a follow up unit test, rather than hold out for one.

@eileenmcnaughton eileenmcnaughton merged commit a7813bf into civicrm:master Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcdservices @seamuslee001 @eileenmcnaughton @civicrm-builder