Civi\API\ExternalBatch - Improve test for variables_order/$_ENV #9969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent revision civicrm#9595 updated `ExternalBatch` to produce a more informative error message. However, in the test environment used by `flexmailer`, there was exactly 1 value in `$_ENV` (even if `variables_order` was misconfigured). This should make the test a bit harder to trip-up by affirmatively checking for the most common environment variable. Review note: In the known universe, the only direct references to `ExternalBatch` are in `CiviUnitTestCase`, so this shouldn't impact any runtime logic.
|
I think Jenkins is the appropriate reviewer for this patch as it affects tests only, and is an 'author-update' |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
Civi\API\ExternalBatch - Improve test for variables_order/$_ENV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent revision #9595 updated
ExternalBatchto produce a moreinformative error message. However, in the test environment used by
flexmailer, there was exactly 1 value in$_ENV(even ifvariables_orderwas misconfigured).This should make the test a bit harder to trip-up by affirmatively checking
for the most common environment variable.
Review note: In the known universe, the only direct references to
ExternalBatchare inCiviUnitTestCase, so this shouldn't impact anyruntime logic.